Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary connection as default path #353

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Primary connection as default path #353

merged 3 commits into from
Aug 29, 2023

Conversation

katrinewi
Copy link
Contributor

@katrinewi katrinewi commented Aug 24, 2023 •
edited
Loading

fixes https://github.com/NDLANO/Issues/issues/3672

Testing:

  • kan feks navigere til /subject:52b154e8-eb71-49cb-b046-c41303eb9b99/topic:82833c09-9b23-4bc7-9e30-e72486ddef06/resource:aff3157f-94df-4937-b95b-a95c873d2886 via artikkelsøk også se at man nå tas til primærkobling

@katrinewi katrinewi requested a review from a team August 24, 2023 10:11
@gunnarvelle
Copy link
Member

Du kan godt bruke contexts for å plukke pathen som brukes når du sender inn subjectId også.

gunnarvelle
gunnarvelle reviewed Aug 28, 2023
View reviewed changes
src/api/searchApi.ts Outdated Show resolved Hide resolved
@katrinewi @gunnarvelle
Update src/api/searchApi.ts
6ca87c9 
Co-authored-by: Gunnar Velle <[email protected]>
@katrinewi katrinewi requested a review from gunnarvelle August 28, 2023 08:56
gunnarvelle
gunnarvelle approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@katrinewi katrinewi merged commit ea14d99 into master Aug 29, 2023
2 checks passed
@katrinewi katrinewi deleted the primary_connection_as_default branch August 29, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnarvelle gunnarvelle gunnarvelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katrinewi @gunnarvelle